fix: check that prediction_proba is not None before checking its type #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtria91
approved these changes
Jul 1, 2024
bigmoby
approved these changes
Jul 1, 2024
dtria91
approved these changes
Jul 1, 2024
rivamarco
approved these changes
Jul 1, 2024
lorenzodagostinoradicalbit
deleted the
hotfix/prediction_proba_can_be_none
branch
maocorte
pushed a commit
that referenced
this pull request
Jul 16, 2024
…#61) * fix: check that prediction_proba is not None before checking its type * fix: using matched value to populate ValueError text * fix: removed ModelType in ValueError text --------- Co-authored-by: lorenzodagostinoradicalbit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing errors in main branch
we need to check that
prediction_probafield is not None before checking the type.This will fix the issue